head & foot: make table.height optional, warn in table-header mixin
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When no
|
| let fixed = this.get('fixed'); | ||
| let height = this.get('sharedOptions.height'); | ||
|
|
||
| warn( |
There was a problem hiding this comment.
should we wrap in a https://www.emberjs.com/api/#method_runInDebug
There was a problem hiding this comment.
Shouldn't be necessary as warn is supposed to be an empty function in a production build. I have not actually verified this though.
There was a problem hiding this comment.
Just checked Ember.warn in our production deployment. It's indeed an empty function. 😄
alexander-alvarez
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446.